Add container scanning #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jappe999
previously approved these changes
Jan 17, 2025
|
@kamphuisem, Quite a lot of the CVE's that were reported, were marked as won't-fix by the authors. This would prevent us from releasing anything. I've upgraded the dependencies which did include fixes in the Docker image and instructed the "scan image" step to ignore unresolved security issues in external packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the GitHub Actions workflow for the delivery process. The changes primarily focus on enhancing the build and security scan processes.
Enhancements to GitHub Actions workflow:
.github/workflows/delivery.yml: Added support for triggering the workflow on pull request events, including synchronize, opened, and reopened types..github/workflows/delivery.yml: Modified the job to build the container and export it to the local Docker instead of pushing it directly to the GitHub Container Registry..github/workflows/delivery.yml: Added a step to scan the Docker image using Anchore and upload the SARIF report..github/workflows/delivery.yml: Updated the final step to conditionally push the image to the GitHub Container Registry only if the event is not a pull request.